Skip to content

fix(ci): Resolve syntax error in zip.yml #15425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 22, 2025
Merged

fix(ci): Resolve syntax error in zip.yml #15425

merged 9 commits into from
Oct 22, 2025
+8 −18

Conversation

@ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Oct 17, 2025 •
edited
Loading

Next up:

Follow-up work

  • Migrate away from Ruby Xcodeproj (make an issue pot.)

#no-changelog

@ncooke3 ncooke3 changed the title dnm: Test nc/quickstarts branch fix(ci): Resolve syntax error in zip.yml Oct 17, 2025
ncooke3
ncooke3 commented Oct 17, 2025
View reviewed changes
Gemfile
@@ -1,4 +1,5 @@
# To update, change version below, run bundle install, test,
#
Copy link
Member Author

@ncooke3 ncooke3 Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#

ncooke3
ncooke3 commented Oct 17, 2025
View reviewed changes
ncooke3
ncooke3 commented Oct 17, 2025
View reviewed changes
ncooke3
ncooke3 commented Oct 17, 2025
View reviewed changes
ncooke3
ncooke3 commented Oct 17, 2025
View reviewed changes
Copy link
Member Author

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@ncooke3 ncooke3 marked this pull request as ready for review October 17, 2025 18:39
@ncooke3 ncooke3 closed this Oct 22, 2025
@ncooke3 ncooke3 reopened this Oct 22, 2025
ncooke3
ncooke3 commented Oct 22, 2025
View reviewed changes
@ncooke3 ncooke3 merged commit f7a8628 into nc/quickstarts Oct 22, 2025
308 of 313 checks passed
@ncooke3 ncooke3 deleted the nc/quickstarts-global branch October 22, 2025 16:51
@ncooke3
Copy link
Member Author

ncooke3 commented Oct 22, 2025 •
edited
Loading

Next up:

  • Test against fix: Fail scripts/add_framework_script.rb if given target DNE quickstart-ios#1790 (simple revert of DB fix)
  • QS– cleanup Swift suffixes (including infra)
  • FB– cleanup Swift suffixes (including infra)
  • Remove PINNED_RUN_ID: '17965877651' and manual references to nc/quickstarts
  • Remove Gemfile trigger
  • Testing team onboarding
  • Merge both branches to main in quickstart and firebase repos
  • Re-usable workflows for zip

Follow-up work

  • Migrate away from Ruby Xcodeproj (make an issue pot.)

#no-changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ncooke3